Skip to content

chore: Fix vulnerability astro #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

chore: Fix vulnerability astro #254

merged 1 commit into from
Apr 17, 2025

Conversation

@suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Apr 17, 2025

Bump astro v4 version in our example and integration test to resolve vulnerability
Closes https://github.com/codecov/internal-issues/issues/1301

@codecov
Copy link

codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (af1b7a9) to head (648493c).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Plugin core 98.05% <ø> (ø)
Rollup plugin 8.42% <ø> (ø)
Vite plugin 8.42% <ø> (ø)
Webpack plugin 56.84% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Components Coverage Δ
Plugin core 98.05% <ø> (ø)
Rollup plugin 8.42% <ø> (ø)
Vite plugin 8.42% <ø> (ø)
Webpack plugin 56.84% <ø> (ø)

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Apr 17, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 1.08MB (16.24%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
@codecov/nuxt-plugin-esm 3.21kB 2.36kB (275.56%) ⬆️⚠️
@codecov/example-astro-app-server-esm 473.27kB 473.27kB (100%) ⬆️⚠️
@codecov/example-astro-5-app-server-esm 600.39kB 600.39kB (100%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: @codecov/bundle-analyzer-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 2.77kB 2.77kB 100.0% 🚀
cli.d.ts (New) 342 bytes 342 bytes 100.0% 🚀
index.d.cts (Deleted) -2.77kB 0 bytes -100.0% 🗑️
cli.d.cts (Deleted) -342 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/astro-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts (New) 862 bytes 862 bytes 100.0% 🚀
index.d.cts (Deleted) -862 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-astro-5-app-server-esm

App Routes Affected:

App Route Size Change Total Size Change (%)
/ (New) 5.78kB 5.78kB 100% 🚀
view changes for bundle: @codecov/example-next-app-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/8uuFk5N_XBxu9XPwWpJ1w/_buildManifest.js (New) 224 bytes 224 bytes 100.0% 🚀
static/8uuFk5N_XBxu9XPwWpJ1w/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/WqbZPZ2NsNwIfet-*.js (Deleted) -224 bytes 0 bytes -100.0% 🗑️
static/WqbZPZ2NsNwIfet-*.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/vite-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 1.24kB 1.24kB 100.0% 🚀
index.d.mts (Deleted) -1.24kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-next-15-app-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
server/middleware-*.js 873 bytes 909 bytes 2425.0% ⚠️
server/middleware-*.js -873 bytes 36 bytes -96.04%
static/UktxdNHQNLSc1tR9v87tZ/_buildManifest.js (New) 540 bytes 540 bytes 100.0% 🚀
static/UktxdNHQNLSc1tR9v87tZ/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/LWDmGkjuE5HAl0glbFxBN/_buildManifest.js (Deleted) -540 bytes 0 bytes -100.0% 🗑️
static/LWDmGkjuE5HAl0glbFxBN/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/nuxt-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.mjs (New) 3.21kB 3.21kB 100.0% 🚀
index.d.ts (Deleted) -855 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/webpack-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.mts (New) 3.45kB 3.45kB 100.0% 🚀
index.d.cts (Deleted) -3.45kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/sveltekit-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.cts (New) 891 bytes 891 bytes 100.0% 🚀
index.d.mts (Deleted) -891 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-astro-app-server-esm

App Routes Affected:

App Route Size Change Total Size Change (%)
/not-pre-rendered (New) 5.54kB 5.54kB 100% 🚀
/ (New) 5.47kB 5.47kB 100% 🚀
view changes for bundle: @codecov/bundler-plugin-core-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 14.67kB 14.67kB 100.0% 🚀
index.d.cts (Deleted) -14.67kB 0 bytes -100.0% 🗑️

@codecov-staging
Copy link

codecov-staging bot commented Apr 17, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 1.08MB (16.71%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
@codecov/nuxt-plugin-esm 3.21kB 2.36kB (275.56%) ⬆️⚠️
@codecov/bundle-analyzer-esm 6.9kB 3.79kB (122.05%) ⬆️⚠️
@codecov/nextjs-webpack-plugin-esm 4.86kB 3.74kB (336.0%) ⬆️⚠️
@codecov/rollup-plugin-esm 1.3kB -5.11kB (-79.7%) ⬇️
@codecov/sveltekit-plugin-esm 3.03kB 2.13kB (239.62%) ⬆️⚠️
@codecov/remix-vite-plugin-esm 957 bytes -2.06kB (-68.26%) ⬇️
@codecov/webpack-plugin-esm 8.89kB 5.43kB (157.49%) ⬆️⚠️
@codecov/example-sveltekit-app-client-esm 727.49kB -2 bytes (-0.0%) ⬇️
@codecov/example-sveltekit-app-server-esm 984.45kB -1 bytes (-0.0%) ⬇️
@codecov/example-astro-app-server-esm 473.27kB 473.27kB (100%) ⬆️⚠️
@codecov/example-astro-5-app-server-esm 600.39kB 600.39kB (100%) ⬆️⚠️

Affected Assets, Files, and Routes:

view changes for bundle: @codecov/example-sveltekit-app-server-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
chunks/internal.js -1 bytes 18.48kB -0.01%
view changes for bundle: @codecov/nuxt-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.mjs (New) 3.21kB 3.21kB 100.0% 🚀
index.d.ts (Deleted) -855 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-next-15-app-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/VdpT0BiJbpvZdycUxHe9n/_buildManifest.js (New) 540 bytes 540 bytes 100.0% 🚀
static/VdpT0BiJbpvZdycUxHe9n/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/yISaf4Fc2NEhnUObxIYcw/_buildManifest.js (Deleted) -540 bytes 0 bytes -100.0% 🗑️
static/yISaf4Fc2NEhnUObxIYcw/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/vite-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.cts (New) 1.24kB 1.24kB 100.0% 🚀
index.d.ts (Deleted) -1.24kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/remix-vite-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 957 bytes 957 bytes 100.0% 🚀
index.mjs (Deleted) -3.02kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/nextjs-webpack-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.mjs (New) 4.86kB 4.86kB 100.0% 🚀
index.d.cts (Deleted) -1.11kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-astro-5-app-server-esm

App Routes Affected:

App Route Size Change Total Size Change (%)
/ (New) 5.78kB 5.78kB 100% 🚀
view changes for bundle: @codecov/sveltekit-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.mjs (New) 3.03kB 3.03kB 100.0% 🚀
index.d.mts (Deleted) -891 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/rollup-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.cts (New) 1.3kB 1.3kB 100.0% 🚀
index.mjs (Deleted) -6.41kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-sveltekit-app-client-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
_app/immutable/chunks/entry.*.js -2 bytes 31.45kB -0.01%
view changes for bundle: @codecov/astro-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.d.ts (New) 862 bytes 862 bytes 100.0% 🚀
index.d.mts (Deleted) -862 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/webpack-plugin-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.mjs (New) 8.89kB 8.89kB 100.0% 🚀
index.d.cts (Deleted) -3.45kB 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/bundle-analyzer-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
index.mjs (New) 3.92kB 3.92kB 100.0% 🚀
cli.mjs (New) 2.98kB 2.98kB 100.0% 🚀
index.d.cts (Deleted) -2.77kB 0 bytes -100.0% 🗑️
cli.d.cts (Deleted) -342 bytes 0 bytes -100.0% 🗑️
view changes for bundle: @codecov/example-astro-app-server-esm

App Routes Affected:

App Route Size Change Total Size Change (%)
/not-pre-rendered (New) 5.54kB 5.54kB 100% 🚀
/ (New) 5.47kB 5.47kB 100% 🚀
view changes for bundle: @codecov/example-next-app-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/S499sQaQwz8M2sbw9XjMH/_buildManifest.js (New) 224 bytes 224 bytes 100.0% 🚀
static/S499sQaQwz8M2sbw9XjMH/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/XZV1DsvrP9vPJhJvY_QPs/_buildManifest.js (Deleted) -224 bytes 0 bytes -100.0% 🗑️
static/XZV1DsvrP9vPJhJvY_QPs/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@suejung-sentry suejung-sentry merged commit 0ac5be0 into main Apr 17, 2025
69 checks passed
@suejung-sentry suejung-sentry deleted the sshin/1301 branch April 17, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spalmurray spalmurray spalmurray approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suejung-sentry @spalmurray